fsharp / fsharp/fslang-design

[style-guide] Format mutation expressions on their own line

Open
#663 11 comments 1 reaction 0 assignees View on GitHub
style-guide style-guide-decided
Dominant language
F#
Stars
557
Forks
149
Avg merge
4d 13h
Merged PRs (30d)
2

Description

I have a strong dislike of code where `->` and `<-` appear on the same line:

```fsharp
let f x =
let mutable keepGoing = false
match x with
| Some _ -> ()
| None -> keepGoing <- false
```

Because this code is relatively rare I think we should consider a style guide entry to explicitly say "put this on two lines"

```fsharp
let f x =
let mutable keepGoing = false
match x with
| Some _ ->
()
| None ->
keepGoing <- false
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the issue's 11-comment discussion, since no file or test is identified in the payload. Done means recording the proposed line-break rule in the project's style guide after the discussion reaches a decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
fsharp
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.