frontend-collective / frontend-collective/react-sortable-tree

Use preset classnames instead of inline style for Responsive design

Open
#912 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
914
PR merge metrics
No merged PRs in 30d

Description

At present, most styles are implemented by **Inline Style**, it's not friendly for responsive design. I think it's better to use the **Preset Classnames**. for example:

```
= rst rst-theme-{themeName}
== rst-container
=== rst-list
==== rst-item rst-item--depth-{depth} rst-item--has-children rst-item--expanded rst-item--draggable etc.
===== rst-item__header
====== rst-item__handle
====== rst-item__title
===== rst-item__body
==== rst-item rst-item--depth-2 rst-item--collapsed
```

Keeping css style separated from rendering allows us to have more flexible control for responsive design, and also makes the component code less messy and easier to debug and maintain.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.