frontend-collective / frontend-collective/react-sortable-tree

frontend-collective-react-dnd-scrollzone has dependency issues

Open
#753 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5k
Forks
914
PR merge metrics
No merged PRs in 30d

Description

Looking at the requires for that frontend-collective-react-dnd-scrollzone in package.json, it's messed up:
```
"frontend-collective-react-dnd-scrollzone": {
"version": "1.0.2",
...
"requires": {
"hoist-non-react-statics": "^3.1.0",
"lodash.throttle": "^4.0.1",
"prop-types": "^15.5.9",
"raf": "^3.2.0",
"react": "^16.3.0",
"react-display-name": "^0.2.0",
"react-dom": "^16.3.0"
}
},
```

This is a dependency of react-storable-tree@2.7.1. This should not require react, react-dom in the released package. This is making react/react-dom load twice in my app and I can't use the control. Jest tests are failing etc due to multiple react versions being loaded etc.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.