frontend-collective / frontend-collective/react-sortable-tree
Why clone NodeContent inside a TreeNode?
Open
- Dominant language
- JavaScript
- Stars
- 5k
- Forks
- 914
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/frontend-collective/react-sortable-tree/blob/master/src/tree-node.js#L154
Why do you use cloneElement() in this part? It seems to be bad for performance.
Should not you just use the NodeRenderer directly? For example
```
```
and
```
class TreeNode extends Component {
render() {
...
return
....
...
}
}
```
Are there any other issues I do not know?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.