frintjs / frintjs/frint

frint-react: Move subscription to componentDidMount in `observe` HoC

Open
#417 1 comment 1 reaction 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
756
Forks
33
PR merge metrics
No merged PRs in 30d

Description

At the moment, it's happening in `componentWillMount`, which is not recommended.

Contributor guide

Open the contributing guide

Research direction

Start in the frint-react package and locate the observe HoC's componentWillMount implementation. Move the subscription lifecycle work to componentDidMount, then verify that the HoC still subscribes correctly without using the deprecated lifecycle method.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.