frintjs / frintjs/frint

Match package versions after hoisting

Open
#402 0 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
756
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Since we introduced `$ lerna bootstrap --hoist`, we now notice that versions of some third-party dependencies within the packages do not match the versions as defined in root `package.json`.

We need to fix them.

```
lerna WARN EHOIST_ROOT_VERSION The repository root depends on react@^16.0.0, which differs from the more common react@^15.5.4.
lerna WARN EHOIST_PKG_VERSION "frint-react-server" package depends on react@^15.5.4, which differs from the hoisted react@^16.0.0.
lerna WARN EHOIST_ROOT_VERSION The repository root depends on react-dom@^16.0.0, which differs from the more common react-dom@^15.5.4.
lerna WARN EHOIST_PKG_VERSION "frint-react-server" package depends on react-dom@^15.5.4, which differs from the hoisted react-dom@^16.0.0.
lerna WARN EHOIST_PKG_VERSION "frint-cli" package depends on lodash@^4.17.4, which differs from the hoisted lodash@^4.13.1.
lerna WARN EHOIST_PKG_VERSION "frint-router" package depends on lodash@^4.17.4, which differs from the hoisted lodash@^4.13.1.
```

Contributor guide

Open the contributing guide

Research direction

Inspect the root package.json and the package manifests for frint-react-server, frint-cli, and frint-router. Compare their React, react-dom, and lodash versions with the root versions, then run lerna bootstrap --hoist and confirm the listed version warnings are resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.