frintjs / frintjs/frint

frint-router: improve test coverage

Open
#268 0 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
756
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Current coverage report:

```
$ (cd ./packages/frint-router && npm run cover:report)

---------------------------|----------|----------|----------|----------|----------------|
File | % Stmts | % Branch | % Funcs | % Lines |Uncovered Lines |
---------------------------|----------|----------|----------|----------|----------------|
All files | 98.76 | 82.35 | 100 | 98.73 | |
makeRouterService.js | 100 | 85 | 100 | 100 | 53,76 |
makeRouterService.spec.js | 100 | 100 | 100 | 100 | |
matchFromHistory.js | 89.47 | 78.57 | 100 | 88.89 | 6,30 |
matchFromHistory.spec.js | 100 | 100 | 100 | 100 | |
---------------------------|----------|----------|----------|----------|----------------|
```

Contributor guide

Open the contributing guide

Research direction

Run the coverage command from the issue in packages/frint-router, then inspect makeRouterService.js lines 53 and 76 and matchFromHistory.js lines 6 and 30. Read the corresponding .spec.js files to follow existing test patterns. Done means the uncovered lines are exercised and the coverage report improves.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.