fregante / fregante/webext-content-scripts

It injects into all frames if a tab number is provided (`injectContentScript(1, scripts)`)

Open
#30 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
25
Forks
3
PR merge metrics
No merged PRs in 30d

Description

I don't remember why I made this choice in https://github.com/fregante/webext-content-scripts/commit/206ab8b11d95d94f9474062b39cef53d35f415c7

https://github.com/fregante/webext-content-scripts/blob/baca20c4d6fb48f3b8a75a2ba0351b2936c6f137/index.ts#L29-L39

This can be avoided by passing a full target instead: `injectContentScript({tabId: 1 frameId:1}, scripts)`

But it's unexpected when calling `injectContentScript(tab, scriptsStraightFromManifest)` like I'm doing in https://github.com/fregante/webext-inject-on-install/pull/3

I have to review how changing this would affect my usage elsewhere.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.