freenowtech / freenowtech/wave

Bigger version of the `InlineSpinner`

Open
#443 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
67
Forks
31
Avg merge
1d 8h
Merged PRs (30d)
4

Description

## Describe the feature you'd like

The current version of the spinner has two sizes - _small_ and _medium_.

We should have a bigger variant so the spinner can be used on a bigger card while the data is loading.
It could have the following style:
```
width: 2rem;
height: 2rem;
border-width: .175rem;
```

### Describe alternatives you've considered

The alternative to an extra size is to allow the user to pass a number to the `size` property. This would work but there are two downsides:
- it is harder to keep the size of different spinners consistent across pages and projects
- the size is mapped to three properties: `height`, `width` and `border-width`. We need extra logic to calculate the border width based on an arbitrary size in pixels or rems

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.