freenowtech / freenowtech/wave

Not possible to reuse a previously rendered banner after the dismiss transition

Open
#376 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
67
Forks
31
Avg merge
1d 8h
Merged PRs (30d)
4

Description

- `@freenow/wave` version: 1.27.0

### Relevant code

https://codesandbox.io/s/wave-playground-forked-9hlttk?file=/src/App.js

### What was expected to happen?

It should be possible to reuse a previously rendered banner after the transition has ended.

### Reproduction

1. Open the playground: https://codesandbox.io/s/wave-playground-forked-9hlttk?file=/src/App.js
2. Click on the "add banner" button several times — this will add several elements to the queue
3. See that the first banner is rendered correctly
4. Dismiss the shown banner by clicking the "close" button
5. See that the next banner in queue is not show
---
7. As a workaround, enable the key prop of the banner component — retry the steps and see that each element in the queue renders a banner

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.