freenowtech / freenowtech/phrase-java-client

Branch not used when checking out locale

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
7
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Hi there, hope this project is still maintained?

I noticed I always get a 404 exception when trying to download a branch of any project, e.g.
```
PhraseAppSyncTask task =
new PhraseAppSyncTask(tok, id, Collections.singletonList("my-branch-name"), "https://api.phraseapp.com");
task.run();
```
Reason is the `branch` parameter is never used:
https://github.com/freenowtech/phrase-java-client/blob/master/src/main/java/com/freenow/apis/phrase/api/locale/PhraseLocaleAPI.java#L92

Fix attached

Best regards
Tom

[use-branch-params.patch](https://github.com/user-attachments/files/18749528/use-branch-params.patch)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.