freedomofpress / freedomofpress/securedrop-dev
Lint remaining GHA workflows
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
We don't really have any credentials in CI, the main thing is that the client and workstation repos have push tokens for apt-test/yum-test/build-logs (the last one is probably the most sensitive).
https://woodruffw.github.io/zizmor/ is one I had seen previously on lobsters and now it's mentioned on https://blog.pypi.org/posts/2024-12-11-ultralytics-attack-analysis/ so we should give it a shot.
It's written in Rust and the recommendation is to cargo install it, so we can do something like https://github.com/freedomofpress/securedrop/blob/develop/.github/workflows/cargo-vet.yml
Primary repositories
- securedrop-client: https://github.com/freedomofpress/securedrop-client/pull/2331
- securedrop-workstation: https://github.com/freedomofpress/securedrop-workstation/pull/1222
- securedrop: https://github.com/freedomofpress/securedrop/pull/7401
- securedrop-builder: https://github.com/freedomofpress/securedrop-builder/pull/507
- securedrop-https-everywhere-ruleset: https://github.com/freedomofpress/securedrop-https-everywhere-ruleset/pull/215
Docs repos
- securedrop-dev-docs
- securedrop-docs
- securedrop-workstation-docs
Package repositories
n.b. these don't have a Python toolchain setup
- securedrop-yum-test
- securedrop-yum-prod
- securedrop-apt-test
- securedrop-apt-prod
Misc
- kernel-builder
- securedrop-supply-chain
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the unchecked repositories' GitHub Actions workflows, using the linked securedrop .github/workflows/cargo-vet.yml example as a starting point. Try zizmor against the workflows in securedrop-dev-docs, securedrop-docs, securedrop-workstation-docs, the package repositories, kernel-builder, and securedrop-supply-chain. Done means the remaining workflows are linted and any findings are addressed or documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, rust
- Domain
- ci-cd, devops, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100