fraserxu / fraserxu/ionic-rating

lib is not minifcation safe

Open
#33 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
CoffeeScript
Stars
141
Forks
55
PR merge metrics
No merged PRs in 30d

Description

I have a useref task, which is outputting one single lib.js file (including ionic-rating).
Afterwards I am gulp-uglify'ing that lib.js file. Unfortunately my dist app doesn't work anymore because ionic-rating is not minification safe.

**As is:**
`.controller('RatingController', function($scope, $attrs, ratingConfig) {...`
and
`.directive('rating', function($timeout) {...`

**To be:**
`.controller('RatingController', ['$scope', '$attrs', 'ratingConfig', function($scope, $attrs, ratingConfig) {...`
and
`.directive('rating', ['$timeout', function($timeout) {...`

Another solution could be **ngInject**, instead of using the DI-array.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.