Signup flow Improvements

continuation of #2372

- [x] Trial for other products from the same account
- [x] Show trial banner to only FC team members
- [x] Remove error 30s (OTP validation)
- [x] Don’t show GST info in the address summary (billing overview)
- [x] Ability to add apps with a + from the site's app switcher
- [x] Wrong numbering on the onboarding page
- [x] No way to navigate to the dashboard from the site login
- [x] Remove OTP flow from framework (just do login from dashboard) (https://github.com/frappe/frappe/commit/8ae69624d6385f65dc23d8197963a665693131eb)
- [x] Fix trial date when standby site is older it shows wrong date (75406e98d3c36260ea773af19153334d27d37678)
- [x] Navigate user to Welcome page on first login (when payment method isn't added)
- [x] OTP improvements
- [x] Limit OTP attempts
- [x] Produce a proper random OTP
- [x] Add attempt tracker (https://github.com/frappe/press/pull/2517
- [x] ~~Use the same password as fc on the site~~ we going passwordless
- [ ] Integrate existing saas customers into the new flow
- [ ] They should be able to explore FC somehow
- [ ] Test email notifications
- [x] Give user a meaningful subdomain (like we used to do) but without renames (#2477)
- [x] Do redirect from /login instead of at /logout
- [x] Show trial banner for user not on fc (contact system admin)
- [ ] Don't use frappeclient for user sync
- [x] Otp flow only for FC, if longer session (https://github.com/frappe/press/pull/2517)
- [x] Login attempt tracker for OTP attempts (https://github.com/frappe/press/pull/2517)
- [x] Remove skip setup wizard and instead only prefill them
- [x] Remove adding/editing billing address detail in add card dialog (https://github.com/frappe/press/commit/ce1ccfb3f1db43f70cc64553a8dc7b5d952e473a)
- [x] Site Overview "visit site" should go to app specific page or /apps

### Low priority
- [ ] Link product trial in drip email

Changes in framework side is done on https://github.com/frappe/frappe/pull/31205

### Issues identified on 20/02/25

1. **On ERPNext signup page**

- [ ] It is not clear that account is being created on FC
- [ ] Password field for FC but logo is ERPNext (remove password field)

2. **Setup screen (after email)**
- [ ] ERPNext related setup fields are shown like CoA and Financial Year Start here (should they be inside erpnext)
- [ ] Prefill good defaults (like financial year and CoA start based on country)

3. **Inside site**
- [x] Upgrade banner takes user to welcome screen (this might be confusing) (https://github.com/frappe/frappe/pull/31205)
- [ ] Maybe educate user before routing them to FC
- [x] Add “Billing” link somewhere (route to FC)
- [x] When routing to FC, take them to site detail page (https://github.com/frappe/frappe/pull/31205)
- [x] Site detail page should have clear next steps for payment, setting plan, etc (#2493)

4. **Site detail**
- [x] Creation date is misleading (https://github.com/frappe/press/commit/062590c393eb2c47f6846b2805558412fff02d48)
- [ ] IP is not required (show it in domain tab)
- [x] Upgrade button is disabled (this is confusing) (#2493)

5. **On FC**
- [x] Payment flow should be in a modal on the site detail screen itself (#2493)
- [x] Welcome screen might be confusing (maybe keep it only for direct FC signups) (#2493)

6. First site Payment flow
- [x] If Add Money is selected, min amount should be based on plan selected (#2493)
- [x] Maybe the flow should be: (#2493)
- (Educate user that they can come back anytime to setup payment, they can use the site on trial, payment should start tracking after trial)
- Select plan
- Address
- Add card or Add money
- Add money (based on plan selected)

### 4 March

- [x] You already have a trial site click on visit button to visit
- [x] Add fc button in site's login page instead of redirect (https://github.com/frappe/frappe/pull/31541)
- [ ] Show trial status in site-login page
- [ ] Show app logo in site-login
- [ ] Don't complete setup wizard instead prefill it
- [ ] Route user to /apps instead of /desk or /crm
- [ ] Sync user from every site