frappe / frappe/ecommerce_integrations

Cannot get any sync or connection to Shopify

Open
#327 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
206
Forks
275
Avg merge
54m
Merged PRs (30d)
1

Description

I cannot get my frappe cloud instance of erpnext to sync anything with my Shopify. I cannot even save the settings because it says it can find the webhopks JSON or something. Below is the error information from the app:
# App Versions

```

{

"chat": "0.0.1",

"crm": "1.19.0",

"ecommerce_integrations": "1.20.1",

"email_delivery_service": "0.0.1",

"erpnext": "15.32.0",

"frappe": "15.37.0",

"helpdesk": "0.10.0",

"hrms": "15.25.2",

"payments": "0.0.1",

"raven": "1.6.5"

}

```

### Route

```

Form/Shopify Setting/Shopify Setting

```

### Traceback

```

Traceback (most recent call last):

File "apps/frappe/frappe/[app.py](http://app.py/)", line 114, in application

response = frappe.api.handle(request)

^^^^^^^^^^^^^^^^^^^^^^^^^^

File "apps/frappe/frappe/api/__init__.py", line 49, in handle

data = endpoint(**arguments)

^^^^^^^^^^^^^^^^^^^^^

File "apps/frappe/frappe/api/[v1.py](http://v1.py/)", line 36, in handle_rpc_call

return frappe.handler.handle()

^^^^^^^^^^^^^^^^^^^^^^^

File "apps/frappe/frappe/[handler.py](http://handler.py/)", line 49, in handle

data = execute_cmd(cmd)

^^^^^^^^^^^^^^^^

File "apps/frappe/frappe/[handler.py](http://handler.py/)", line 85, in execute_cmd

return [frappe.call](http://frappe.call/)(method, **frappe.form_dict)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "apps/frappe/frappe/__init__.py", line 1768, in call

return fn(*args, **newargs)

^^^^^^^^^^^^^^^^^^^^

File "apps/frappe/frappe/utils/typing_[validations.py](http://validations.py/)", line 31, in wrapper

return func(*args, **kwargs)

^^^^^^^^^^^^^^^^^^^^^

File "apps/ecommerce_integrations/ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_[products.py](http://products.py/)", line 19, in get_shopify_products

shopify_products = fetch_all_products(from_)

^^^^^^^^^^^^^^^^^^^^^^^^^

File "apps/ecommerce_integrations/ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_[products.py](http://products.py/)", line 29, in fetch_all_products

for product in collection:

TypeError: 'NoneType' object is not iterable

```

### Request Data

```

{

"type": "POST",

"args": {

"from_": null

},

"headers": {},

"error_handlers": {},

"url": "/api/method/ecommerce_[integrations.shopify.page](http://integrations.shopify.page/).shopify_import_products.shopify_import_products.get_shopify_products",

"request_id": "c826fd73-1b64-4eb2-ab2e-cb6bb83deea5"

}

```

### Response Data

```

{

"exception": "TypeError: 'NoneType' object is not iterable",

"exc_type": "TypeError",

"_exc_source": "ecommerce_integrations (app)"

}

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_products.py, especially get_shopify_products and fetch_all_products at the traceback lines. Reproduce the Shopify Setting save or product-import request using the supplied route and request data, then trace why the collection is None. Done means the settings can be saved and Shopify products can be synchronized without the reported TypeError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.