frappe / frappe/ecommerce_integrations

Issue getting products from Shopify.

Open
#309 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
207
Forks
276
Avg merge
54m
Merged PRs (30d)
1

Description

I am getting an issue getting product from shopify.

App Versions
{
	"builder": "1.4.0",
	"doppio": "0.0.1",
	"ecommerce_integrations": "1.17.0",
	"erpnext": "15.13.0",
	"frappe": "15.13.0",
	"hrms": "16.0.0-dev",
	"raven": "1.3.2",
	"studio_dashboard": "0.0.1",
	"vendor": "0.0.1"
}
Route
shopify-import-products
Traceback
Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 110, in application
    response = frappe.api.handle(request)
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1682, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_products.py", line 19, in get_shopify_products
    shopify_products = fetch_all_products(from_)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_products.py", line 30, in fetch_all_products
    for product in collection:
TypeError: 'NoneType' object is not iterable

Request Data
{
	"type": "POST",
	"args": {
		"from_": null
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/ecommerce_integrations.shopify.page.shopify_import_products.shopify_import_products.get_shopify_products",
	"request_id": null
}
Response Data
{
	"exception": "TypeError: 'NoneType' object is not iterable",
	"exc_type": "TypeError",
	"_exc_source": "ecommerce_integrations (app)"
}

When I use the credentials I used to connect to shopify separately I am getting the products.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_products.py, especially get_shopify_products and fetch_all_products at the traceback lines. Inspect how the null from_ request value reaches collection, then verify the Shopify product import route no longer raises a NoneType iteration error and products can be retrieved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.