frappe / frappe/datatable

Bug with serialNoColumn= false

Open
#218 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.3k
Forks
216
PR merge metrics
No merged PRs in 30d

Description

That line:
[ ${props.colIndex === 0 ? 'disabled' : title}](https://github.com/frappe/datatable/blob/5c5aeed554b10f84b9e65406bea44b8d2bf9d7b0/src/rowmanager.js#L363)
incorrectly handle absent serialNo column.
Recommended change:
`props.colIndex< this.datamanager.getStandardColumnCount()`

Thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.