frappe / frappe/builder

OG and Favicons are uploaded as private files

Closed
#834 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
2.4k
Forks
534
Avg merge
1d 2h
Merged PRs (30d)
45

Description

**Describe the bug**
When uploaded through the builder's interface, the OG image and Favicons are saved as private files.

I think these should be public, the favicon doesn't render for guests users (asserted this though manual check)

Have not seen abnormalities with the OG image, but it makes sense to keep that as public as well

**Expected behavior**
Favicons and OG images are public by default

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing an OG image and favicon upload through the builder's interface, then trace where their file visibility is assigned. Done means both asset types are public by default and a guest can render the favicon; verify the behavior for both assets after upload.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.