frappe / frappe/builder

Dark mode image variants don't shrink

Open
#714 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
2.4k
Forks
534
Avg merge
1d 4h
Merged PRs (30d)
46

Description

https://github.com/user-attachments/assets/9d5c7607-e568-4c8d-b0d3-84089245f07b

When dark mode image variants are added, they don't take up the flex-shrink and dimension values of light mode images? Causes other images to shift or shrink. Not sure if this is a technical constraint.

The issue seems to be resolved if the picture tag is set to display: block instead of display: contents.

Image

(currently enforced using external stylesheet)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the picture-tag rendering and the stylesheet rules controlling display, flex-shrink, and dimensions. Reproduce the layout with light and dark image variants, compare display: contents with display: block, and verify that neighboring images retain their expected size and position.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.