frappe / frappe/builder

feat: improved unit support

Open
#108 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2.4k
Forks
534
Avg merge
1d 2h
Merged PRs (30d)
45

Description

Here are two major improvements that could be made to units support, as it occurs to me:

- [ ] Allow for setting a global default unit in the settings, between:
- cm
- em
- in
- in
- mm
- pc
- pt
- px
- rem
- [ ] Respect any manually-set units when using mouse-dragging to reset sizing in the visual editor. In other words, if the width, height, margin, or padding are set to something other than pixels, resizing any of these attributes in the canvas should retain and accordingly resize the attributes while respecting the unit override, instead of reverting to the default unit (which is pixels at present).

Contributor guide

No contributing guide indexed for this repository

Research direction

No files, tests, or entry points are named. Start by locating the settings flow and the visual-editor mouse-drag resizing behavior described in the issue, then trace how units are currently selected and retained. Done means a configurable default unit works and resizing width, height, margin, and padding preserves manually selected non-pixel units.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.