frappe / frappe/bench

Option to set gunicorn --limit-request-line from common_site_config.json

Open
#770 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

Issue: Feature Request

**Is your feature request related to a problem? Please describe.**
Sometimes default value of gunicorn `--limit-request-line` (which is 4094) is not enough. I have encountered `Bad Request : Request Line is too large (6010 > 4094)` several times, and mostly when select doctype in Data Export page on ERPNext (ver 11).

**Describe the solution you'd like**
In `supervisor.conf`, add `--limit-request-line` option to gunicorn command, and add config getter in `generate_supervisor_config` function so it could get the config from `common_site_config.json` file.

**Additional context**

![image](https://user-images.githubusercontent.com/22533767/52389064-f0e46500-2ac3-11e9-9513-220a0c2d3426.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating supervisor.conf and the generate_supervisor_config function, then trace how common_site_config.json values are read into the generated Gunicorn command. Confirm the existing configuration path and make the requested limit-request-line setting appear in the generated command when configured. Done means a common_site_config.json value controls Gunicorn's request-line limit without breaking supervisor configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.