frankframework / frankframework/frankframework

Create filename parameter and get rid of attribute in FixedResultPipe

Open
#11,110 3 comments 0 reactions 0 assignees View on GitHub
Developer Experience FF! Config Parameter
Dominant language
Java
Stars
167
Forks
87
Avg merge
1d 2h
Merged PRs (30d)
206

Description

I've suggested this on other PR's before, but what about using an actual `Param` and get rid of this attribute? 😄

_Originally posted by @Laurens-makel in https://github.com/frankframework/frankframework/issues/11084#issuecomment-4782544936_

---

Add a special parameter which holds the filename instead of using the `filename` or `filenameSessionkey` attributes.

May cause problems when you wish to replace a variable called `filename`.

Contributor guide

Open the contributing guide

Research direction

Start by locating FixedResultPipe and reading how its filename and filenameSessionkey attributes are handled, along with the existing Param conventions. Replace the attribute-based filename handling with the proposed special parameter, account for variables named filename, and verify the affected behavior with the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.