frankframework / frankframework/frank-doc

Opportunity for code cleanup in FrankDocModel.createAttributes()

Open
#178 2 comments 0 reactions 1 assignee Claimed by @mhdirkse View on GitHub
doclet
Dominant language
Java
Stars
5
Forks
5
Avg merge
1h 20m
Merged PRs (30d)
1

Description

Two tasks of this method can be removed:

1. Currently, a getter that accompanies an attribute setter is used for type checking. The return type of the getter is compared with the argument type of the setter. This check becomes irrelevant because getters may be hidden. Getters that are done with Lombok @Getter will not be visible when the de-lombok step is out of the F!F build.
2. Attributes of an enum type will always have the enum as argument type. The check for getXxxEnum() to find the enum type will become irrelevant and can be removed.

See https://github.com/frankframework/frankframework/issues/6344.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.