foxcpp / foxcpp/maddy

Enforce reasonable timeouts for all routines

Open
#370 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.1k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

As part of the goal to improve maddy robustness, context.Context should be used
consistently in all interfaces and reasonable timeouts for operations should be enforced
using these.

- [ ] SMTP check methods
- [ ] SMTP modifier methods
- [ ] IMAP commands (server)
- [ ] SMTP commands (server)
- [ ] Delivery target operations

With that considered, maddy should have as much operations as possible implemented
in a rollback-able way so composite operations could be cancelled due to timeout in one of
sub-operations.

Notable considerations:
- [ ] Delivery.AddRcpt should be revertable. At least last call should be.

With current implementation (non-revertable AddRcpt), it is possible that if multiple delivery targets are used
for one recipient, duplicate messages may be delivered in case of partial failures.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.