foxcpp / foxcpp/maddy

remote: Fix support for IP literals in recipient addresses

Open
#176 2 comments 0 reactions 0 assignees View on GitHub
bug good first issue mta-out
Dominant language
Go
Stars
6.1k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

Since a lot of authentication mechanisms are keyed on the MX or domain name, the IP literals support uses the rDNS domain of the IP address. This assumes forward-confirmed rDNS, but it should be fine for most mail servers.

~~There is, however, an issue with current implementation: it assumes the returned rDNS name is a recipient domain, not a MX what is not true for many mail servers.~~
~~The correct behavior is to construct MX candidates list from rDNS names.~~

**The new implementation of "security policies" broke it altogether and it is disabled now.**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.