foxcpp / foxcpp/go-imap-sql

Flags/PermanentFlags somehow contains an empty string

Open
#44 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
26
Forks
12
PR merge metrics
No merged PRs in 30d

Description

originally reported here: https://github.com/emersion/go-imap/issues/544
tl;dr: go-imap-sql inserts an empty string to Flags, which then gets incorrectly serialized in go-imap for the SELECT response and becomes impossible to get parsed back by go-imap itself

looks like the logic for collecting flags from the mailbox is wrong:
https://github.com/foxcpp/go-imap-sql/blob/c0176dad/mailbox.go#L128-L137

the simplest fix would be
```go
if flag == "" {
continue
}
```

though i'm not sure why it even happens

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.