foundry-rs / foundry-rs/foundry

ECDSA signature generation does not follow RFC-6979

Open
#9,499 2 comments 6 reactions 0 assignees View on GitHub
A-dependencies T-blocked T-chore
Dominant language
Rust
Stars
10.6k
Forks
2.6k
Avg merge
18h 20m
Merged PRs (30d)
510

Description

The ECDSA signatures generated by the `vm.sign()` cheatcode do not strictly follow RFC-6979. For more info regarding the details, see [this analysis](https://github.com/obatirou/RFC6979-implementation-analysis?tab=readme-ov-file).

Note that the underlying ECDSA functionality is provided via [RustCrypto](https://github.com/RustCrypto/elliptic-curves) which fixed the issue in a recent prerelease, see https://github.com/RustCrypto/elliptic-curves/issues/1100.

Creating this as tracking issue, can be closed once foundry updates to the new RustCrypto version.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.