foundry-rs / foundry-rs/foundry
feat(wallets): reuse `session_id` across multiple `TrezorSigner`
- Dominant language
- Rust
- Stars
- 10.6k
- Forks
- 2.6k
- Avg merge
- 16h 38m
- Merged PRs (30d)
- 511
Description
### Component
Forge
### Describe the feature you would like
https://github.com/foundry-rs/foundry/blob/398ef4a3d55d8dd769ce86cada5ec845e805188b/crates/wallets/src/multi_wallet.rs#L369-L375
Currently, every new instance of `TrezorSigner` is created with their own `session_id`. If a passphrase is enabled on the device, it means requesting it for every mnemonic index.
Ideally, each `TrezorSigner` reuses the first created `session_id`.
### Additional context
_No response_
Contributor guide
Research direction
Start in crates/wallets/src/multi_wallet.rs at the linked lines 369-375 and trace how each TrezorSigner receives its session_id. The change is complete when multiple TrezorSigner instances reuse the first session_id instead of requesting a passphrase for every mnemonic index.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100