Orbit height wrong if picture + source + img lazy loading
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 29.8k
- Forks
- 5.4k
- Avg merge
- 25m
- Merged PRs (30d)
- 1
Description
What should happen?
The height of the slider should be calculated after source selection and the lazy loading happened.
What happens instead?
The orbit-container gets a much lesser height on first uncached page load.
...
Possible Solution
...
Test Case and/or Steps to Reproduce (for bugs)
Test Case: https://jsfiddle.net/kajvsu7b/6/
Context
...
Your Environment
- Foundation version(s) used: 6.8.1
- Browser(s) name and version(s): edge 119
- Device, Operating System and version: Mac
- Link to your project:
Checklist
- I have read and follow the CONTRIBUTING.md document.
- There are no other issues similar to this one.
- The issue title and template are correctly filled.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked JSFiddle and reproduce the issue using Foundation 6.8.1 on an uncached load, focusing on the Orbit container, picture/source selection, and lazy-loaded image timing. Trace the Orbit implementation and verify that the container height is calculated only after the image source and lazy loading have completed; done means the initial height matches subsequent cached loads.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100