foundation / foundation/panini

Inconsistencies in helpers

Open
#148 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
593
Forks
104
PR merge metrics
No merged PRs in 30d

Description

I am using both of the **code** and **markdown** helpers in my templates.

I noticed a minor difference between them.

The **code** helper wraps the markup with a `DIV.code-example` layer:

```html

%s

```

However, the **markdown** helper, doesn't use the same _highlight.js_ treatment for any code block the markdown content may have.

Since I need this functionality, I'm looking into a workaround to it. My first impression is creating a new markdown helper implementing the same highlight.js logic, and use that instead.

Is there something obvious I am missing?
Thanks

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the code and markdown helpers and compare how each renders code blocks. Check the existing highlight.js treatment used by the code helper, then determine how markdown content should receive equivalent handling. Done means markdown code blocks receive the expected highlighting and the behavior is covered by the project's relevant tests, if present.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.