fossasia / fossasia/pslab-python
START_COUNTING used, but it is not implemened
Open
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 242
- PR merge metrics
- No merged PRs in 30d
Description
The logic analyzer instrument used the START_COUNTING command, but it is not supported by the current firmware.
https://github.com/fossasia/pslab-python/blob/8ae580effcddaf4d341e66098a96beab77f86b3d/pslab/instrument/logic_analyzer.py#L746
What should be done instead: Measure like in the `measure_frequency` method, but don't divide the period.
Contributor guide
Assessment
This issue has not been assessed yet.