fosrl / fosrl/newt

bug?: incorrect log information

Open Beginner friendly
#287 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
908
Forks
87
Avg merge
1d 15h
Merged PRs (30d)
7

Description

https://github.com/fosrl/newt/blob/b6f13a1b5531e26e530f14e0d2b172c399a8deaa/authdaemon/server.go#L166

It logs we listen on `127.0.0.1` which is incorrect we should drop `https` and the hardcoded `127.0.0.1` and just say "listening on addr" user understands that `:port` means all interfaces in most cases.

This will also prepare use if we allow to change the bind interface.

Contributor guide

Open the contributing guide

Research direction

Read authdaemon/server.go around line 166 and inspect the listen log statement. Update the message to report the listen address without the https scheme or hardcoded 127.0.0.1, then verify the resulting log wording and run the relevant Go tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.