forwardemail / forwardemail/supertest

`abort` broken in 6.2.2 release

Open
#763 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
14.4k
Forks
782
PR merge metrics
No merged PRs in 30d

Description

A regression related to aborting requests seems to have occurred in the `supertest` 6.1.6 => 6.2.2 release. `superagent` was upgraded at that time so the root cause may be there.

Requests do not appear to be receiving the "aborted" event when aborted via `supertest`.

I originally reproduced in Node 14.16.1 but confirmed that the same behavior affects 16.14.0 as well.

Repro: https://github.com/jimmydief/supertest-abort-bug-repro

```
System:
OS: macOS 11.6.4
Binaries:
Node: 14.16.1 - /usr/local/bin/node
npm: 6.14.12 - /usr/local/bin/npm
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.