forwardemail / forwardemail/supertest

expect(500) passes if statusCode is undefined

Open
#745 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
14.4k
Forks
782
PR merge metrics
No merged PRs in 30d

Description

Was just using this library to write a test.

Being TDD, I wrote the test first and was expecting the code to return 500.

But the code was never written and actually threw so `statusCode` was not defined.

The test passed.

Don't think `500 === undefined` is correct. I believe `expect` should fail in that case.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.