forwardemail / forwardemail/superagent
req.redirects changed in version 1.0.0: port is missing
- Dominant language
- JavaScript
- Stars
- 16.6k
- Forks
- 1.3k
- PR merge metrics
- No merged PRs in 30d
Description
After upgrading to 1.0.0 or 1.1.0 the following rest fails. In earlier versions the test succeeded.
``` javascript
var app = require('express')();
var request = require('superagent');
var assert = require('assert');
app.get('/',function(req,res){
res.redirect('/login');
});
app.get('/login',function(req,res){
res.send('Hello World!');
});
var port=4325;
app.listen(port);
describe('server', function () {
describe('GET /', function () {
it('should redirect to login page', function (done) {
request
.get('localhost:'+port+'/')
.end(function (err, res) {
assert.deepEqual(res.redirects,[ 'localhost:'+port+'/login' ]);
done();
});
});
});
});
```
```
1) server GET / should redirect to login page:
Uncaught AssertionError: ["localhost:/login"] deepEqual ["localhost:4325/login"]
```
Contributor guide
Assessment
This issue has not been assessed yet.