forwardemail / forwardemail/superagent

req.redirects changed in version 1.0.0: port is missing

Open
#596 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

After upgrading to 1.0.0 or 1.1.0 the following rest fails. In earlier versions the test succeeded.

``` javascript
var app = require('express')();
var request = require('superagent');
var assert = require('assert');

app.get('/',function(req,res){
res.redirect('/login');
});
app.get('/login',function(req,res){
res.send('Hello World!');
});
var port=4325;
app.listen(port);

describe('server', function () {
describe('GET /', function () {
it('should redirect to login page', function (done) {
request
.get('localhost:'+port+'/')
.end(function (err, res) {
assert.deepEqual(res.redirects,[ 'localhost:'+port+'/login' ]);
done();
});
});
});
});
```

```
1) server GET / should redirect to login page:
Uncaught AssertionError: ["localhost:/login"] deepEqual ["localhost:4325/login"]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.