forwardemail / forwardemail/superagent
`drain` once is not good
Open
- Dominant language
- JavaScript
- Stars
- 16.6k
- Forks
- 1.3k
- PR merge metrics
- No merged PRs in 30d
Description
[this](https://github.com/visionmedia/superagent/pull/1084/commits/dc18679a7c5ccfc6046d882015e5126888973bc8) PR to address #1084 changed the `re-emitter` of `drain` to once... which is not good. Piping a large stream into a request hangs indefinitely because request only drains once. Listener should be `on` and cleaned up after `close` is emitted.
https://github.com/visionmedia/superagent/blob/29fd1f917a6cc78c9a2a9984269c06f8b4e63dcb/src/node/index.js#L821-L823
Contributor guide
Assessment
This issue has not been assessed yet.