forwardemail / forwardemail/superagent

Node Download Progress Never Fires

Open
#1,604 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

I'm trying to use the `.on('progress', cb)` method for a download in my Node application, but the callback function is never called. For uploads, `.on('progress', cb)` works just fine.

Relevant versions:
- node: 12.14.1
- superagent: 6.1.0
- typescript: 4.0.5
- ts-node: 9.0.0

Download example (does not work):
```ts
agent()
.get(downloadUrl)
.maxResponseSize(this.maxDownloadSize ?? 200_000_000)
.on('progress', ev => {
console.log('Progress: ', ev.loaded);
})
.then(r => {
console.log("Response body: ', r.body);
});
```

Upload example (works):
```ts
agent()
.post(uploadUrl)
.attach('file1', bufferToUpload, {filename: 'thing1.zip', contentType: 'application/zip'})
.on('progress', ev => {
console.log('Progress: ', ev.loaded);
})
.then(r => {
console.log("Response body: ', r.body);
});
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.