forwardemail / forwardemail/superagent

"double callback bug" is logged when http2 error occur

Open
#1,598 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

If I request an non-http2 server with http2 superagent throws error with `superagent: double callback bug`.
Wondering if this is an expected behavior for http2?

#### Sample code
```javascript
superagent
.get('https://github.com')
.http2()
.then(console.log)
.catch(console.log)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.