forwardemail / forwardemail/superagent

abort will not emit error if retry is set.

Open
#1,596 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

When the retry count is set. call abort() on the request won't throw the Abort Error. And the retry callback's param can not get the Abort Error.((err, res) => boolean). Since the abort function is called by user. I think the request should not retry or it should pass the abort error to the retry callback and leave it for user to decide?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.