forwardemail / forwardemail/superagent

http2 check should not use process.version

Open
#1,580 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Super agent as check where it automatically use http2 by just checking node version. This is not a good idea as like us people might have custom version of node that compile out certain features of node. A check like `typeof process.versions.nghttp2 !== undefined` could be better way of telling if node support http2 or not.

Thanks

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.