forwardemail / forwardemail/superagent
Response object is not sent to callback
Open
- Dominant language
- JavaScript
- Stars
- 16.6k
- Forks
- 1.3k
- PR merge metrics
- No merged PRs in 30d
Description
It looks like the response object is not sent back to callback when an exception is thrown:
```
this.on('end', function () {
var err = null;
var res = null;
try {
res = new Response(self);
} catch (err_) {
// ...
return self.callback(err); // <-- HERE
}
// ...
});
```
Contributor guide
Research direction
Start by locating the `end` handler containing `new Response(self)` and the `self.callback(err)` line shown in the issue. Trace the callback contract around this exception path; done means the callback receives the response object when the exception is thrown, without changing other error handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100