forwardemail / forwardemail/superagent

Missing async trace in Node V12

Open
#1,484 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Node V12 supports full async stack trace, but superagent error stack still missing the outter async stack trace when there is error thrown from super agent, e.g a server 500 internal error.
Is there anything need to be fixed from superagent side to keep the async stack trace?

at Response.toError (C:\dev\LT\wise-report-center\node_modules\superagent\lib\node\response.js:98:13)
at ResponseBase._setStatusProperties (C:\dev\LT\wise-report-center\node_modules\superagent\lib\response-base.js:119:48)
at new Response (C:\dev\LT\wise-report-center\node_modules\superagent\lib\node\response.js:44:8)
at Request._emitResponse (C:\dev\LT\wise-report-center\node_modules\superagent\lib\node\index.js:909:18)
at C:\dev\LT\wise-report-center\node_modules\superagent\lib\node\index.js:1105:42
at IncomingMessage. (C:\dev\LT\wise-report-center\node_modules\superagent\lib\node\parsers\json.js:22:7)
at IncomingMessage.emit (events.js:201:15)
at endReadableNT (_stream_readable.js:1130:12)
at processTicksAndRejections (internal/process/task_queues.js:84:17)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.