forwardemail / forwardemail/superagent

use encodeURIComponent instead of encodeURI for query parameters

Open
#1,364 1 comment 0 reactions 0 assignees View on GitHub
Awaiting feedback
Dominant language
JavaScript
Stars
16.6k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Right now, the normal string gets encoded using encodeURI, which might need some correction to use encodeURIComponent.
For ex: ```name=alice&age=20``` works fine
whereas, ```name=alice&bruno&age=20``` fails since the first `&` is part of the first query parameter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.