formulahendry / formulahendry/vscode-github-actions
Inline comments vs expressions
- Dominant language
- TypeScript
- Stars
- 15
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
This seems to assumes anything after a '#' is a comment, which isn't always true. e.g. Line 10 and 12, assumes `${GITHUB_REF##*/}` is a comment.
Example taken from https://stackoverflow.com/a/58034787/6305204
Unfortunately, this probably needs to be more complicated than `"match": "#.*"
`
https://github.com/formulahendry/vscode-github-actions/blob/a711d409ffd481675cd072c7df94c75252b21eda/syntaxes/workflow.tmLanguage.json#L19
Since github action files are essentially yaml, maybe you could borrow from some vscode yaml extensions? e.g. https://github.com/redhat-developer/vscode-yaml/blob/d609a0f7bf987c2c3aac47720218e754a7ce9fba/syntaxes/yaml.tmLanguage.json#L160
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.