formly-js / formly-js/angular-formly-website

Error in JSBin Remove property on hide

Open
#106 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
18
Forks
24
PR merge metrics
No merged PRs in 30d

Description

There is a bug in this JS Bin;
http://jsbin.com/sufate/edit?js,output

An infinite recursion error is caused by line 18.

This is the function:

```
function removeOnHideTransformer(fields) {
return fields.map(function(field) {
field.data = field.data || {};
if (field.key && !field.noFormControl && field.hideExpression && !field.data.dontRemoveOnHidden) {
addFieldRemoveOnHideWatcher(field);
} else if (field.fieldGroup) {
field.fieldGroup = removeOnHideTransformer(fields);
}
return field;
});
}
```

This code

```
else if (field.fieldGroup) {
field.fieldGroup = removeOnHideTransformer(fields);
}
```

Should be

```
else if (field.fieldGroup) {
field.fieldGroup = removeOnHideTransformer(field.fieldGroup);
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.