forkingdog / forkingdog/FDFullscreenPopGesture
fd_viewControllerBasedNavigationBarAppearanceEnabled should be defaulted to NO and should be honored in the viewWillDisappear method
- Dominant language
- Objective-C
- Stars
- 5.9k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
When using this library it will create various issues since it is swizzling all instances of UINavigationController. The default for controlling the navigation bar appearance, fd_viewControllerBasedNavigationBarAppearanceEnabled, should be NO so that it doesn't conflict with other implementations. The user should specify if they want to turn this feature on.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the UINavigationController category code that defines fd_viewControllerBasedNavigationBarAppearanceEnabled and the viewWillDisappear implementation. Check how the property is initialized and whether that lifecycle method consults it; done means the default is NO and the setting is honored without changing explicitly enabled behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100