forcedotcom / forcedotcom/code-analyzer

[BUG][code-analyzer] Disabled rules are moved to the end of the config file rules list

Open
#2,019 3 comments 0 reactions 0 assignees View on GitHub
BUG P3
Dominant language
TypeScript
Stars
240
Forks
52
Avg merge
1d 23h
Merged PRs (30d)
5

Description

### Have you tried to resolve this issue yourself first?

- [x] I confirm I have gone through the above steps and still have an issue to report.

### Bug Description

I disabled some rules and recreated the config file. ( see #2013 )

All the disabled rules were moved to the end of the `pmd` section.

But I want to view ALL the PMD rules alphabetized so I know which ones are in there.

### Output / Logs

```shell

```

### Steps To Reproduce

1. Disabled a rule with `disabled: true`
2. Run `echo 'y' | sf code-analyzer config --include-unmodified-rules --rule-selector all --config-file code-analyzer.yml --output-file code-analyzer.yml`
3. See that the disabled rules are moved.

### Expected Behavior

All rules should be alphabetized by their unique key. This extra sort doesn't help anything and only can confuse people.

### Operating System

macOS

### Salesforce CLI Version

@salesforce/cli/2.128.5 darwin-arm64 node-v22.22.1

### Code Analyzer Plugin (code-analyzer) Version

5.11.1

### Node Version

_No response_

### Java Version

_No response_

### Python Version

_No response_

### Additional Context (Screenshots, Files, etc)

Image

This is actually a significant bug because changing from expected behavior will confuse people.

### Workaround

_No response_

### Urgency

Moderate

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.