foam-framework / foam-framework/foam

Add warning when primary key choice for a model will be ignored

Open
#373 0 comments 0 reactions 0 assignees View on GitHub
bug enhancement error-reporting
Dominant language
JavaScript
Stars
783
Forks
51
PR merge metrics
No merged PRs in 30d

Description

Attempting to use ids: ['something'] when extending another model or using traits doesn't produce the expected result. This does make sense, since changing the primary key in a sub-model is dubious, and could be better handled by implementing a property called 'id'.

However a warning to the developer that they have an id assignment that will be ignored would save a lot of headaches. If we do want to allow the primary key to be changed, then this is a bug in buildPrototype().

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.