[Docs] flyte-binary helm chart is missing ServiceMonitor
- Dominant language
- Go
- Stars
- 7.5k
- Forks
- 886
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 120
Description
### Description
Hi Team, the [instructions](https://docs-legacy.flyte.org/en/latest/deployment/configuration/monitoring.html#deployment-configuration-monitoring) for prometheus setup for flyte-binary deployment instruct people to add config properties for the microservices bundled in flyte-binary and expose an extra http port 10254 for the service monitor. However, no `ServiceMonitor` (which is the CRD object telling prometheus to pull from flyte /meterics) is included in the flyte-binary helm chart.
Requesting the addition of a `ServiceMonitor` resource to the flyte-binary helm chart to complete the prometheus metrics setup for flyte-binary. Currently, I have to create it as a template in my project.
Something similar to the flyte-core admin [service-monitor.yaml](https://github.com/flyteorg/flyte/blob/master/charts/flyte-core/templates/admin/service-monitor.yaml)
### Are you sure this issue hasn't been raised already?
- [x] Yes
### Have you read the Code of Conduct?
- [x] Yes
Contributor guide
Assessment
This issue has not been assessed yet.