flydelabs / flydelabs/flyde-vscode

[Bug] "View all" nodes results in an error

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When trying to "view all" nodes in the VS Code extension, VS code reports an error in the Flyde extension.

Clicking this button:
Screenshot 2024-05-21 at 11 46 24

Leads to this error message:
Screenshot 2024-05-21 at 11 46 33

This is the entry from the log:
```
2024-05-21 11:36:58.383 [error] TypeError: Cannot read properties of undefined (reading 'executionId')
at Socket. (/Users/moi/.vscode/extensions/flyde.flyde-vscode-0.62.0/node_modules/@flyde/remote-debugger/dist/setup-server.js:138:41)
at Socket.emit (node:events:517:28)
at Socket.emit (node:domain:489:12)
at Socket.emitUntyped (/Users/moi/.vscode/extensions/flyde.flyde-vscode-0.62.0/node_modules/socket.io/dist/typed-events.js:69:22)
at /Users/moi/.vscode/extensions/flyde.flyde-vscode-0.62.0/node_modules/socket.io/dist/socket.js:704:39
at processTicksAndRejections (node:internal/process/task_queues:77:11)
```

This is the line in the code that is the culprit of the problem:
```typescript
// setup-server.js, line 138
const executionId = data[0].executionId; // this assumes all events in the batch are from the same execution. TODO - check this assumption
```

Looks like this assumption is invalid 😉

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.